Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Side by Side Diff: src/ic/ic-inl.h

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/mips/ic-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_INL_H_ 5 #ifndef V8_IC_INL_H_
6 #define V8_IC_INL_H_ 6 #define V8_IC_INL_H_
7 7
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 9
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 DCHECK(result->is_inline_cache_stub()); 91 DCHECK(result->is_inline_cache_stub());
92 return result; 92 return result;
93 } 93 }
94 94
95 95
96 void IC::SetTargetAtAddress(Address address, Code* target, 96 void IC::SetTargetAtAddress(Address address, Code* target,
97 ConstantPoolArray* constant_pool) { 97 ConstantPoolArray* constant_pool) {
98 DCHECK(target->is_inline_cache_stub() || target->is_compare_ic_stub()); 98 DCHECK(target->is_inline_cache_stub() || target->is_compare_ic_stub());
99 99
100 // Don't use this for load_ics when --vector-ics is turned on. 100 // Don't use this for load_ics when --vector-ics is turned on.
101 DCHECK(!(FLAG_vector_ics && target->is_inline_cache_stub()) || 101 DCHECK(!target->is_inline_cache_stub() ||
102 (target->kind() != Code::LOAD_IC && 102 (target->kind() != Code::LOAD_IC &&
103 target->kind() != Code::KEYED_LOAD_IC)); 103 target->kind() != Code::KEYED_LOAD_IC));
104 104
105 Heap* heap = target->GetHeap(); 105 Heap* heap = target->GetHeap();
106 Code* old_target = GetTargetAtAddress(address, constant_pool); 106 Code* old_target = GetTargetAtAddress(address, constant_pool);
107 #ifdef DEBUG 107 #ifdef DEBUG
108 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark 108 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
109 // ICs as language mode. The language mode of the IC must be preserved. 109 // ICs as language mode. The language mode of the IC must be preserved.
110 if (old_target->kind() == Code::STORE_IC || 110 if (old_target->kind() == Code::STORE_IC ||
111 old_target->kind() == Code::KEYED_STORE_IC) { 111 old_target->kind() == Code::KEYED_STORE_IC) {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 inline Code* IC::get_host() { 214 inline Code* IC::get_host() {
215 return isolate() 215 return isolate()
216 ->inner_pointer_to_code_cache() 216 ->inner_pointer_to_code_cache()
217 ->GetCacheEntry(address()) 217 ->GetCacheEntry(address())
218 ->code; 218 ->code;
219 } 219 }
220 } 220 }
221 } // namespace v8::internal 221 } // namespace v8::internal
222 222
223 #endif // V8_IC_INL_H_ 223 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/mips/ic-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698