Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: src/ic/ia32/handler-compiler-ia32.cc

Issue 1129853002: Removing FLAG_vector_ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment response. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 __ mov(result, 123 __ mov(result,
124 FieldOperand(result, JSFunction::kPrototypeOrInitialMapOffset)); 124 FieldOperand(result, JSFunction::kPrototypeOrInitialMapOffset));
125 // Load the prototype from the initial map. 125 // Load the prototype from the initial map.
126 __ mov(result, FieldOperand(result, Map::kPrototypeOffset)); 126 __ mov(result, FieldOperand(result, Map::kPrototypeOffset));
127 } 127 }
128 128
129 129
130 void NamedLoadHandlerCompiler::GenerateLoadFunctionPrototype( 130 void NamedLoadHandlerCompiler::GenerateLoadFunctionPrototype(
131 MacroAssembler* masm, Register receiver, Register scratch1, 131 MacroAssembler* masm, Register receiver, Register scratch1,
132 Register scratch2, Label* miss_label) { 132 Register scratch2, Label* miss_label) {
133 DCHECK(!FLAG_vector_ics); 133 // TODO(mvstanton): This isn't used on ia32. Move all the other
134 __ TryGetFunctionPrototype(receiver, scratch1, scratch2, miss_label); 134 // platform implementations into a code stub so this method can be removed.
135 __ mov(eax, scratch1); 135 UNREACHABLE();
136 __ ret(0);
137 } 136 }
138 137
139 138
140 // Generate call to api function. 139 // Generate call to api function.
141 // This function uses push() to generate smaller, faster code than 140 // This function uses push() to generate smaller, faster code than
142 // the version above. It is an optimization that should will be removed 141 // the version above. It is an optimization that should will be removed
143 // when api call ICs are generated in hydrogen. 142 // when api call ICs are generated in hydrogen.
144 void PropertyHandlerCompiler::GenerateApiAccessorCall( 143 void PropertyHandlerCompiler::GenerateApiAccessorCall(
145 MacroAssembler* masm, const CallOptimization& optimization, 144 MacroAssembler* masm, const CallOptimization& optimization,
146 Handle<Map> receiver_map, Register receiver, Register scratch, 145 Handle<Map> receiver_map, Register receiver, Register scratch,
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 // Return the generated code. 805 // Return the generated code.
807 return GetCode(kind(), Code::NORMAL, name); 806 return GetCode(kind(), Code::NORMAL, name);
808 } 807 }
809 808
810 809
811 #undef __ 810 #undef __
812 } 811 }
813 } // namespace v8::internal 812 } // namespace v8::internal
814 813
815 #endif // V8_TARGET_ARCH_IA32 814 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698