Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2750)

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 1129833003: Rename "register" -> "subscribe" in the Push Messaging code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@p-userVisible-tests
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_push_messaging_service.h
diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.h b/content/shell/browser/layout_test/layout_test_push_messaging_service.h
index 1158963289e785c0f4f825ae363cfe6dded825ed..83b74c86624f88eb14798abbd134e32114bcdef4 100644
--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.h
+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.h
@@ -21,28 +21,28 @@ class LayoutTestPushMessagingService : public PushMessagingService {
// PushMessagingService implementation:
GURL GetPushEndpoint() override;
- void RegisterFromDocument(
+ void SubscribeFromDocument(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,
int renderer_id,
int render_frame_id,
bool user_visible,
- const PushMessagingService::RegisterCallback& callback) override;
- void RegisterFromWorker(
+ const PushMessagingService::SubscribeCallback& callback) override;
+ void SubscribeFromWorker(
const GURL& requesting_origin,
int64 service_worker_registration_id,
const std::string& sender_id,
bool user_visible,
- const PushMessagingService::RegisterCallback& callback) override;
+ const PushMessagingService::SubscribeCallback& callback) override;
blink::WebPushPermissionStatus GetPermissionStatus(
const GURL& requesting_origin,
const GURL& embedding_origin,
bool user_visible) override;
- void Unregister(const GURL& requesting_origin,
- int64 service_worker_registration_id,
- const std::string& sender_id,
- const UnregisterCallback& callback) override;
+ void Unsubscribe(const GURL& requesting_origin,
+ int64 service_worker_registration_id,
+ const std::string& sender_id,
+ const UnsubscribeCallback& callback) override;
private:
DISALLOW_COPY_AND_ASSIGN(LayoutTestPushMessagingService);

Powered by Google App Engine
This is Rietveld 408576698