Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: content/public/browser/push_messaging_service.h

Issue 1129833003: Rename "register" -> "subscribe" in the Push Messaging code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@p-userVisible-tests
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/push_messaging_service.h
diff --git a/content/public/browser/push_messaging_service.h b/content/public/browser/push_messaging_service.h
index c1a6f1cb6a03247deb1bf5a6d9e4ddf34771ddac..3b253b0ae692239103982a7254996db765ea32da 100644
--- a/content/public/browser/push_messaging_service.h
+++ b/content/public/browser/push_messaging_service.h
@@ -22,10 +22,10 @@ class ServiceWorkerContext;
// push messaging services like GCM. Must only be used on the UI thread.
class CONTENT_EXPORT PushMessagingService {
public:
- using RegisterCallback =
- base::Callback<void(const std::string& /* registration_id */,
- PushRegistrationStatus /* status */)>;
- using UnregisterCallback = base::Callback<void(PushUnregistrationStatus)>;
+ using SubscribeCallback =
+ base::Callback<void(const std::string& /* subscription_id */,
+ PushSubscriptionStatus /* status */)>;
+ using UnsubscribeCallback = base::Callback<void(PushUnsubscriptionStatus)>;
using StringCallback = base::Callback<void(const std::string& data,
bool success,
@@ -37,36 +37,36 @@ class CONTENT_EXPORT PushMessagingService {
// Returns the absolute URL exposed by the push server where the webapp server
// can send push messages. This is currently assumed to be the same for all
- // origins and push registrations.
+ // origins and push subscriptions.
virtual GURL GetPushEndpoint() = 0;
- // Register the given |sender_id| with the push messaging service in a
+ // Subscribe the given |sender_id| with the push messaging service in a
// document context. The frame is known and a permission UI may be displayed
// to the user.
- virtual void RegisterFromDocument(const GURL& requesting_origin,
- int64 service_worker_registration_id,
- const std::string& sender_id,
- int renderer_id,
- int render_frame_id,
- bool user_visible,
- const RegisterCallback& callback) = 0;
-
- // Register the given |sender_id| with the push messaging service. The frame
+ virtual void SubscribeFromDocument(const GURL& requesting_origin,
+ int64 service_worker_registration_id,
+ const std::string& sender_id,
+ int renderer_id,
+ int render_frame_id,
+ bool user_visible,
+ const SubscribeCallback& callback) = 0;
+
+ // Subscribe the given |sender_id| with the push messaging service. The frame
// is not known so if permission was not previously granted by the user this
// request should fail.
- virtual void RegisterFromWorker(const GURL& requesting_origin,
- int64 service_worker_registration_id,
- const std::string& sender_id,
- bool user_visible,
- const RegisterCallback& callback) = 0;
-
- // Unregister the given |sender_id| from the push messaging service. The
- // registration will be synchronously deactivated locally, and asynchronously
+ virtual void SubscribeFromWorker(const GURL& requesting_origin,
+ int64 service_worker_registration_id,
+ const std::string& sender_id,
+ bool user_visible,
+ const SubscribeCallback& callback) = 0;
+
+ // Unsubscribe the given |sender_id| from the push messaging service. The
+ // subscription will be synchronously deactivated locally, and asynchronously
// sent to the push service, with automatic retry.
- virtual void Unregister(const GURL& requesting_origin,
- int64 service_worker_registration_id,
- const std::string& sender_id,
- const UnregisterCallback& callback) = 0;
+ virtual void Unsubscribe(const GURL& requesting_origin,
+ int64 service_worker_registration_id,
+ const std::string& sender_id,
+ const UnsubscribeCallback& callback) = 0;
// Checks the permission status for the requesting origin. Permission is only
// ever granted when the requesting origin matches the top level embedding
@@ -98,9 +98,9 @@ class CONTENT_EXPORT PushMessagingService {
int64 service_worker_registration_id,
const StringCallback& callback);
- // Clear the push registration id stored in the service worker with the given
+ // Clear the push subscription id stored in the service worker with the given
// |service_worker_registration_id| for the given |origin|.
- static void ClearPushRegistrationID(BrowserContext* browser_context,
+ static void ClearPushSubscriptionID(BrowserContext* browser_context,
const GURL& origin,
int64 service_worker_registration_id,
const base::Closure& callback);

Powered by Google App Engine
This is Rietveld 408576698