src/compiler.cc - Issue 1129823002: Remove Scope::scope_uses_this_ flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1129823002: Remove Scope::scope_uses_this_ flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 2ad1ff447e26d51a7b4750ab979e8a9b96d0a1bb..262817c912ba9750b6acb6db8cb9cf7cdb3d175a 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -215,8 +215,7 @@ bool CompilationInfo::is_simple_parameter_list() {

bool CompilationInfo::MayUseThis() const {

- return scope()->uses_this() || scope()->inner_uses_this() ||

- scope()->calls_sloppy_eval();

+ return scope()->has_this_declaration() && scope()->receiver()->is_used();

}

« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | src/preparser.h » ('J')