Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1129813004: Possible deferencing from nullptrs in AtkComponent interface. (Closed)

Created:
5 years, 7 months ago by k.czech
Modified:
5 years, 7 months ago
Reviewers:
shreeramk, dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Possible deferencing from nullptrs in AtkComponent interface. Make sure AtkComponent interface callbacks operate on valid pointers. GetExtent and GetPosition are almost the same. Reducing some code by adding helper method SetExtentsRelativeToAtkCoordinateType. BUG=463671 Committed: https://crrev.com/98cb52ed6cc58b257d590ef1cfe9e83eb1b01d1a Cr-Commit-Position: refs/heads/master@{#329664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -25 lines) Patch
M ui/accessibility/platform/ax_platform_node_auralinux.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 4 chunks +54 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
k.czech
5 years, 7 months ago (2015-05-12 22:59:05 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-05-13 16:42:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129813004/1
5 years, 7 months ago (2015-05-13 16:42:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 17:23:09 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:23:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98cb52ed6cc58b257d590ef1cfe9e83eb1b01d1a
Cr-Commit-Position: refs/heads/master@{#329664}

Powered by Google App Engine
This is Rietveld 408576698