Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1129803003: PPC: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Resolve references to "this" the same way as normal variables Port 18619d355192e2699203d12d9ebb9caea107b693 Original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>;. R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/e0ec097b2f49c4c99a2e9490f4b1a09e02abfd4d Cr-Commit-Position: refs/heads/master@{#28272}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/ppc/full-codegen-ppc.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-06 15:46:43 UTC) #1
wingo
lgtm (non-owner) https://codereview.chromium.org/1129803003/diff/1/src/ppc/lithium-codegen-ppc.cc File src/ppc/lithium-codegen-ppc.cc (right): https://codereview.chromium.org/1129803003/diff/1/src/ppc/lithium-codegen-ppc.cc#newcode122 src/ppc/lithium-codegen-ppc.cc:122: !info_->is_native() && info_->scope()->has_this_declaration()) { Might want to ...
5 years, 7 months ago (2015-05-06 15:56:43 UTC) #2
dstence
lgtm
5 years, 7 months ago (2015-05-06 16:00:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129803003/1
5 years, 7 months ago (2015-05-06 16:02:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 16:30:14 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0ec097b2f49c4c99a2e9490f4b1a09e02abfd4d Cr-Commit-Position: refs/heads/master@{#28272}
5 years, 7 months ago (2015-05-06 16:30:18 UTC) #7
MTBrandyberry
5 years, 7 months ago (2015-05-07 22:15:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1132513005/ by mbrandy@us.ibm.com.

The reason for reverting is: Original commit was reverted..

Powered by Google App Engine
This is Rietveld 408576698