Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1129803002: IDL: Make v8_utilities.py not depend on v8_types.py (Closed)

Created:
5 years, 7 months ago by Jens Widell
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Make v8_utilities.py not depend on v8_types.py This is useful since v8_types.py depends on v8_utilities.py, indirectly. Thus, if v8_utilities.py imports v8_types like it currently does, it is not possible to import v8_utilities unless v8_types has been imported first. All v8_utilities.py actually used from v8_types.py was a helper function that returns a string with 'V8' prepended. I think we can afford to duplicate this functionality. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/bindings/scripts/v8_utilities.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
PTAL Most complicated patch ever. The added import of v8_types here is why: https://codereview.chromium.org/1101583003/diff/80001/Source/bindings/scripts/generate_global_constructors.py
5 years, 7 months ago (2015-05-06 13:37:37 UTC) #2
vivekg
On 2015/05/06 at 13:37:37, jl wrote: > PTAL > > Most complicated patch ever. +1 ...
5 years, 7 months ago (2015-05-06 13:51:29 UTC) #3
haraken
LGTM
5 years, 7 months ago (2015-05-06 13:55:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129803002/1
5 years, 7 months ago (2015-05-06 14:07:13 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 15:46:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194981

Powered by Google App Engine
This is Rietveld 408576698