Browser-wide audio mirroring for TabCapture API

content/browser/renderer_host/media/media_stream_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/media_stream_manager.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 91 matching lines @@
 
     if (options.video_type != MEDIA_TAB_VIDEO_CAPTURE &&
         options.audio_type != MEDIA_TAB_AUDIO_CAPTURE)
       return;
 
     MediaObserver* media_observer =
         GetContentClient()->browser()->GetMediaObserver();
     if (media_observer == NULL)
       return;
 
+    // We expect the device_id without the device_id scheme in chrome/.

[Alpha Left Google, 2012/11/28 01:04:47]

What does this mean?

[justinlin, 2012/11/28 14:30:31]

Clarified the comment.

+    std::string device_id =
+        WebContentsCaptureUtil::StripWebContentsDeviceScheme(
+            requested_device_id);
+
     media_observer->OnMediaRequestStateChanged(
       render_process_id, render_view_id,
       MediaStreamDevice(
-          stream_type, requested_device_id, requested_device_id), new_state);
+          stream_type, device_id, device_id), new_state);
   }
 
   MediaRequestState getState(MediaStreamType stream_type) const {
     return state_[stream_type];
   }
 
   MediaStreamRequester* requester;  // Can be NULL.
   StreamOptions options;
   RequestType type;
   int render_process_id;
@@ skipping 142 matching lines @@
   // this currently exists.  Also, we don't have a user-friendly device name for
   // the infobar UI.
   if (IsAudioMediaType(options.audio_type)) {
     // TODO(justinlin): Updating the state to requested and pending are no-ops
     // in terms of the media manager, but these are the state changes we want to
     // support in terms of extensions (which is registered as an observer).
     request.setState(options.audio_type, MEDIA_REQUEST_STATE_REQUESTED);
     request.setState(options.audio_type, MEDIA_REQUEST_STATE_PENDING_APPROVAL);
     ui_controller_->AddAvailableDevicesToRequest(
         *label, options.audio_type, StreamDeviceInfoArray(
-            1, StreamDeviceInfo(options.audio_type, device_id, device_id,
+            1, StreamDeviceInfo(options.audio_type,

[Alpha Left Google, 2012/11/28 01:04:47]

No need to change this line isn't it?

[justinlin, 2012/11/28 14:30:31]

Done.

+                                device_id,
+                                device_id,
                                 false)));
   }
   if (IsVideoMediaType(options.video_type)) {
     request.setState(options.video_type, MEDIA_REQUEST_STATE_REQUESTED);
     request.setState(options.video_type, MEDIA_REQUEST_STATE_PENDING_APPROVAL);
     ui_controller_->AddAvailableDevicesToRequest(
         *label, options.video_type, StreamDeviceInfoArray(
-            1, StreamDeviceInfo(options.video_type, device_id, device_id,
+            1, StreamDeviceInfo(options.video_type,

[Alpha Left Google, 2012/11/28 01:04:47]

Same for this line.

[justinlin, 2012/11/28 14:30:31]

Done.

+                                device_id,
+                                device_id,
                                 false)));
   }
 }
 
 void MediaStreamManager::CancelRequest(const std::string& label) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   DeviceRequests::iterator it = requests_.find(label);
   if (it != requests_.end()) {
     // The request isn't complete, notify the UI immediately.
@@ skipping 753 matching lines @@
   }
 
   // Always do enumeration even though some enumeration is in progress,
   // because those enumeration commands could be sent before these devices
   // change.
   ++active_enumeration_ref_count_[stream_type];
   GetDeviceManager(stream_type)->EnumerateDevices();
 }
 
 }  // namespace content