alternate ntp: add "Recent Tabs" submenu to wrench menu

chrome/browser/ui/views/toolbar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar_view.h"
 
 #include "base/i18n/number_formatting.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/command_updater.h"
@@ skipping 404 matching lines @@
   return GetWidget()->GetAccelerator(id, accel);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ToolbarView, views::MenuButtonListener implementation:
 
 void ToolbarView::OnMenuButtonClicked(views::View* source,
                                       const gfx::Point& point) {
   DCHECK_EQ(VIEW_ID_APP_MENU, source->id());
 
+  wrench_menu_model_.reset(new WrenchMenuModel(this, browser_));

[sky, 2012/11/07 00:10:47]

This order goes against your comment in the header.

[kuan, 2012/11/07 02:29:46]

my comment in header said wrench_menu_model_ shld be listed later so that it's
destructed earlier.  so here in construction, shldn't it be constructed earlier?

[kuan, 2012/11/07 16:48:52]

now, i understand what u mean; u're right, i shld construct it later.  i forgot
that scoped_ptr::reset will destruct the previous pointer b4 constructing new
one, so i shld reset model first.

   wrench_menu_.reset(new WrenchMenu(browser_));
-  wrench_menu_model_.reset(new WrenchMenuModel(this, browser_));
   wrench_menu_->Init(wrench_menu_model_.get());
 
   FOR_EACH_OBSERVER(views::MenuListener, menu_listeners_, OnMenuOpened());
 
   wrench_menu_->RunMenu(app_menu_);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ToolbarView, LocationBarView::Delegate implementation:
 
@@ skipping 451 matching lines @@
     accname_app = l10n_util::GetStringFUTF16(
         IDS_ACCNAME_APP_UPGRADE_RECOMMENDED, accname_app);
   }
   app_menu_->SetAccessibleName(accname_app);
 
   app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL));
   app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT));
   app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED));
   SchedulePaint();
 }