Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1129793006: Add additional commands in compat mode. (Closed)

Created:
5 years, 7 months ago by David Tseng
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additional commands in compat mode. Committed: https://crrev.com/f78ee2358731401d4a9278fc5c419edd73d65cdc Cr-Commit-Position: refs/heads/master@{#329158}

Patch Set 1 #

Patch Set 2 : Add keycode mapping for space. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/classic_compatibility.js View 1 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
David Tseng
5 years, 7 months ago (2015-05-08 16:57:46 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-05-08 17:25:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129793006/20001
5 years, 7 months ago (2015-05-08 22:40:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:03:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129793006/20001
5 years, 7 months ago (2015-05-11 16:08:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 16:40:44 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 16:41:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f78ee2358731401d4a9278fc5c419edd73d65cdc
Cr-Commit-Position: refs/heads/master@{#329158}

Powered by Google App Engine
This is Rietveld 408576698