Issue 1129793004: ThreadLogMessages: don’t check TLS slot initialization return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129793004: ThreadLogMessages: don’t check TLS slot initialization return value (Closed)

Created:
5 years, 7 months ago by Mark Mentovai

Modified:
5 years, 7 months ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org, Alexei Svitkine (slow)

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

ThreadLogMessages: don’t check TLS slot initialization return value. This updates Crashpad for https://codereview.chromium.org/1124493002/. The mini_chromium update includes: 98264cf63f22 ThreadLocalStorage: remove the return value from slot initialization R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7d454ae71348812e670603c8b9b42e78aae7ca02

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	util/thread/thread_log_messages.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Mark Mentovai

5 years, 7 months ago (2015-05-06 21:04:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7d454ae71348812e670603c8b9b42e78aae7ca02 (presubmit successful).