Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: ios/web/public/web_state/js/crw_js_window_id_manager_unittest.mm

Issue 1129763003: Re-enable JSWindowIDManagerTest.WindowID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/web_state/js/crw_js_window_id_manager_unittest.mm
diff --git a/ios/web/public/web_state/js/crw_js_window_id_manager_unittest.mm b/ios/web/public/web_state/js/crw_js_window_id_manager_unittest.mm
deleted file mode 100644
index 4abc76abdda1b41e179327ff3ff3147262ec8a47..0000000000000000000000000000000000000000
--- a/ios/web/public/web_state/js/crw_js_window_id_manager_unittest.mm
+++ /dev/null
@@ -1,60 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
Eugene But (OOO till 7-30) 2015/05/09 16:40:37 Is there a gyp file which should be changed as a p
Jackie Quinn 2015/05/11 18:21:33 Yes, Done.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import "ios/web/web_state/js/crw_js_window_id_manager.h"
-
-#include "base/mac/scoped_nsobject.h"
-#import "ios/web/public/test/crw_test_js_injection_receiver.h"
-#include "ios/web/public/web_client.h"
-#import "testing/gtest_mac.h"
-#include "testing/platform_test.h"
-
-namespace {
-
-class JSWindowIDManagerTest : public PlatformTest {
- protected:
- void SetUp() override {
- PlatformTest::SetUp();
- receiver_.reset([[CRWTestJSInjectionReceiver alloc] init]);
- manager_.reset([[CRWJSWindowIdManager alloc] initWithReceiver:receiver_]);
- web::SetWebClient(&web_client_);
- }
- void TearDown() override {
- web::SetWebClient(nullptr);
- PlatformTest::TearDown();
- }
- // Required for CRWJSWindowIdManager creation.
- base::scoped_nsobject<CRWTestJSInjectionReceiver> receiver_;
- // Testable CRWJSWindowIdManager.
- base::scoped_nsobject<CRWJSWindowIdManager> manager_;
- // WebClient required for getting early page script, which must be injected
- // before CRWJSWindowIdManager.
- web::WebClient web_client_;
-};
-
-// TODO(jyquinn): enable this test (crbug.com/465898).
-TEST_F(JSWindowIDManagerTest, DISABLED_WindowID) {
- EXPECT_TRUE(manager_.get());
- [manager_ inject];
- NSString* windowID = [manager_ windowId];
- EXPECT_EQ(32U, [windowID length]);
- // Inject a second time to check that the ID is different.
- [manager_ inject];
- NSString* windowID2 = [manager_ windowId];
- EXPECT_FALSE([windowID isEqualToString:windowID2]);
-}
-
-TEST_F(JSWindowIDManagerTest, WindowIDDifferent) {
- [manager_ inject];
- NSString* windowID = [manager_ windowId];
- base::scoped_nsobject<CRWTestJSInjectionReceiver> receiver2(
- [[CRWTestJSInjectionReceiver alloc] init]);
- base::scoped_nsobject<CRWJSWindowIdManager> manager2(
- [[CRWJSWindowIdManager alloc] initWithReceiver:receiver2]);
- [manager2 inject];
- NSString* windowID2 = [manager2 windowId];
- EXPECT_NSNE(windowID, windowID2);
-}
-
-} // namespace

Powered by Google App Engine
This is Rietveld 408576698