Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129763002: Add tests for SVG sizing inside vertical writing mode (Closed)

Created:
5 years, 7 months ago by davve
Modified:
5 years, 7 months ago
Reviewers:
pdr., kojii, fs
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add tests for SVG sizing inside vertical writing mode BUG=484425 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195041

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Patch Set 3 : Full change with updated expected file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
A LayoutTests/svg/in-html/sizing/svg-inline-vertical.html View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
davve
We seem to have no coverage for the combination of vertical writing mode and SVG ...
5 years, 7 months ago (2015-05-06 13:50:49 UTC) #2
davve
5 years, 7 months ago (2015-05-07 06:59:12 UTC) #4
kojii
non-owner LGTM
5 years, 7 months ago (2015-05-07 08:05:17 UTC) #5
fs
lgtm w/ the below fixed https://codereview.chromium.org/1129763002/diff/1/LayoutTests/svg/in-html/sizing/svg-inline-vertical.html File LayoutTests/svg/in-html/sizing/svg-inline-vertical.html (right): https://codereview.chromium.org/1129763002/diff/1/LayoutTests/svg/in-html/sizing/svg-inline-vertical.html#newcode26 LayoutTests/svg/in-html/sizing/svg-inline-vertical.html:26: <svg heigth="200" viewBox="0 0 ...
5 years, 7 months ago (2015-05-07 08:33:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129763002/40001
5 years, 7 months ago (2015-05-07 08:48:26 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 10:09:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195041

Powered by Google App Engine
This is Rietveld 408576698