Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1129753002: [content/browser/service_worker] Using ThreadTaskRunnerHandle in lieu of MessageLoopProxy (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using ThreadTaskRunnerHandle in lieu of MessageLoopProxy in content/browser/service_worker module Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in content/browser/service_worker module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/42756a855e5e4fd4c5aa3b1e8a18fb38b7efc692 Cr-Commit-Position: refs/heads/master@{#328709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -43 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.cc View 8 chunks +20 lines, -16 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 12 chunks +34 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-05-06 09:26:21 UTC) #2
michaeln
lgtm
5 years, 7 months ago (2015-05-06 18:49:17 UTC) #3
anujsharma
On 2015/05/06 18:49:17, michaeln wrote: > lgtm Thanks michaeln for lgtm.
5 years, 7 months ago (2015-05-07 03:17:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129753002/1
5 years, 7 months ago (2015-05-07 03:21:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 04:50:49 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 04:51:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42756a855e5e4fd4c5aa3b1e8a18fb38b7efc692
Cr-Commit-Position: refs/heads/master@{#328709}

Powered by Google App Engine
This is Rietveld 408576698