Issue 1129743002: Gracefully handle backdoor cancellations of synchronous resource fetches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129743002: Gracefully handle backdoor cancellations of synchronous resource fetches. (Closed)

Created:
5 years, 7 months ago by sof

Modified:
5 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit), Nate Chapin, Mike West

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Gracefully handle backdoor cancellations of synchronous resource fetches. When fetching a resource synchronously (via XHR, say), messages can be handled & dispatched while that fetch is ongoing. These may in the general case bring about the cancellation of the resource being synchronously fetched. Be prepared for that eventuality when the (failing) synchronous fetch returns. R=jochen BUG=484101 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194973

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -5 lines)			Patch
A	LayoutTests/plugins/plugin-cancel-sync-xhr.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A +	LayoutTests/plugins/plugin-cancel-sync-xhr-expected.txt	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	Source/core/fetch/ResourceLoader.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129743002/1

5 years, 7 months ago (2015-05-06 13:13:14 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-06 13:17:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194973

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages