Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1129733004: Fix conditional disabling of flaky AutomationApiTest.Mixins (Closed)

Created:
5 years, 7 months ago by brucedawson
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, csharp
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix conditional disabling of flaky AutomationApiTest.Mixins Change https://codereview.chromium.org/1014543006 was supposed to disable AutomationApiTest.Mixins because it is flaky (it fails ~8% of the time on Windows, and is also flaky on Linux). However the disabling didn't work because the newly created MAYBE_Mixins macro is never used. This fixes that by renaming the test. The line that always fails is: assertEq(2, input.textSelStart); The output is: Actual: 0 Expected: 2 R=ellyjones@chromium.org TBR=aboxhall@chromium.org BUG=467921 Committed: https://crrev.com/4e2f4e9ea13d850e16f3aa2c5a9ee2273608f564 Cr-Commit-Position: refs/heads/master@{#330202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
brucedawson
Elly, can you take a look?
5 years, 7 months ago (2015-05-15 20:10:17 UTC) #1
Elly Fong-Jones
lgtm
5 years, 7 months ago (2015-05-15 20:26:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129733004/1
5 years, 7 months ago (2015-05-15 20:31:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 21:25:29 UTC) #5
brucedawson
CCing csharp@ and maniscalco@ to close the loop.
5 years, 7 months ago (2015-05-16 00:01:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e2f4e9ea13d850e16f3aa2c5a9ee2273608f564 Cr-Commit-Position: refs/heads/master@{#330202}
5 years, 7 months ago (2015-05-18 11:27:46 UTC) #7
maniscalco
5 years, 7 months ago (2015-05-18 15:23:35 UTC) #8
Message was sent while issue was closed.
On 2015/05/16 00:01:26, brucedawson wrote:
> CCing csharp@ and maniscalco@ to close the loop.

Good catch.

Powered by Google App Engine
This is Rietveld 408576698