Fix detection of restart needed in VersionUpdaterWin.

Fix detection of restart needed in VersionUpdaterWin.

BUG=488489
TEST=With Chrome SxS running, allow Google Update to download and install an update, then navigate to chrome://help. It should report that a restart is needed.
R=pkasting@chromium.org

Committed: https://crrev.com/f0f3add758865b560217fc546a269459a9aeaa54
Cr-Commit-Position: refs/heads/master@{#330191}

[grt (UTC plus 2), 2015-05-15 16:45:50]

Hi Peter,

Please take a look. I err'd in picking the wrong function to check for a pending
update in the previous refactor. This fixes it. Thanks.

[grt (UTC plus 2), 2015-05-15 17:40:42]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-15 17:41:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129733003/1

[commit-bot: I haz the power, 2015-05-15 17:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 17:46:08]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2015-05-15 18:58:18]

LGTM with question

https://codereview.chromium.org/1129733003/diff/1/chrome/browser/ui/webui/hel...
File chrome/browser/ui/webui/help/version_updater_win.cc (right):

https://codereview.chromium.org/1129733003/diff/1/chrome/browser/ui/webui/hel...
chrome/browser/ui/webui/help/version_updater_win.cc:107: if
(base::PostTaskAndReplyWithResult(
If this conditional fails, we'll run the callback with status CHECKING.  Is that
correct, or should we change to FAILED or NEARLY_UPDATED or something?

[grt (UTC plus 2), 2015-05-15 19:57:16]

Thanks.

https://codereview.chromium.org/1129733003/diff/1/chrome/browser/ui/webui/hel...
File chrome/browser/ui/webui/help/version_updater_win.cc (right):

https://codereview.chromium.org/1129733003/diff/1/chrome/browser/ui/webui/hel...
chrome/browser/ui/webui/help/version_updater_win.cc:107: if
(base::PostTaskAndReplyWithResult(
On 2015/05/15 18:58:18, Peter Kasting wrote:
> If this conditional fails, we'll run the callback with status CHECKING.  Is
that
> correct, or should we change to FAILED or NEARLY_UPDATED or something?

This condition will only fail when Chrome is shutting down. I think running the
callback with UPDATED is good since Chrome will complete the update if there is
one, so from the user's point of view it doesn't matter if the true state was
NEARLY_UPDATED.

[grt (UTC plus 2), 2015-05-15 19:57:20]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2015-05-15 19:57:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1129733003/#ps20001
(title: "handle shutdown case as UPDATED")

[commit-bot: I haz the power, 2015-05-15 19:59:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129733003/20001

[commit-bot: I haz the power, 2015-05-15 20:56:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-18 11:27:15]

Patchset 2 (id:??) landed as
https://crrev.com/f0f3add758865b560217fc546a269459a9aeaa54
Cr-Commit-Position: refs/heads/master@{#330191}