Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1129713003: Add third_party/khronos to GN configs in ozone gbm (Closed)

Created:
5 years, 7 months ago by mkollaro
Modified:
5 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add third_party/khronos to GN configs in ozone gbm The khronos headers are present in GYP, but missing in GN, causing the build using GN to fail when 'ozone_platform_gbm=true' is used. BUG=487108 Committed: https://crrev.com/a16802db6f81062df2fb00d6a7d7f5c04f4dd20c Cr-Commit-Position: refs/heads/master@{#329411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mkollaro
5 years, 7 months ago (2015-05-12 15:04:00 UTC) #1
spang
lgtm
5 years, 7 months ago (2015-05-12 15:05:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129713003/1
5 years, 7 months ago (2015-05-12 15:05:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 15:54:13 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 15:54:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a16802db6f81062df2fb00d6a7d7f5c04f4dd20c
Cr-Commit-Position: refs/heads/master@{#329411}

Powered by Google App Engine
This is Rietveld 408576698