[Media Gallery] Added code to support mtp device media file system on Windows.

chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/system_monitor/removable_device_notifications_window_win.h"
 
 #include <dbt.h>
 
 #include <string>
 #include <vector>
@@ skipping 308 matching lines @@
   // Runs all the pending tasks on UI thread, FILE thread and blocking thread.
   void RunUntilIdle();
 
   void DoMassStorageDeviceAttachedTest(const DeviceIndices& device_indices);
   void DoMassStorageDevicesDetachedTest(const DeviceIndices& device_indices);
 
   // Injects a device attach or detach change (depending on the value of
   // |test_attach|) and tests that the appropriate handler is called.
   void DoMTPDeviceTest(const string16& pnp_device_id, bool test_attach);
 
+  // Gets the MTP details of the storage specified by the |storage_device_id|.
+  // On success, returns true and fills in |pnp_device_id| and
+  // |storage_object_id|.
+  bool GetMTPStorageInfo(const std::string& storage_device_id,
+                         string16* pnp_device_id,
+                         string16* storage_object_id);
+
+  scoped_ptr<TestRemovableDeviceNotificationsWindowWin> window_;
+
+ private:
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
 
   base::SystemMonitor system_monitor_;
   base::MockDevicesChangedObserver observer_;
-  scoped_ptr<TestRemovableDeviceNotificationsWindowWin> window_;
   scoped_refptr<TestVolumeMountWatcherWin> volume_mount_watcher_;
 };
 
 RemovableDeviceNotificationsWindowWinTest::
     RemovableDeviceNotificationsWindowWinTest()
    : ui_thread_(BrowserThread::UI, &message_loop_),
      file_thread_(BrowserThread::FILE, &message_loop_) {
 }
 
 RemovableDeviceNotificationsWindowWinTest::
@@ skipping 138 matching lines @@
             .Times((name.empty() || unique_id.empty()) ? 0 : 1);
       }
     }
   }
   window_->InjectDeviceChange(
       test_attach ? DBT_DEVICEARRIVAL : DBT_DEVICEREMOVECOMPLETE,
       reinterpret_cast<DWORD>(dev_interface_broadcast.get()));
   RunUntilIdle();
 }
 
+bool RemovableDeviceNotificationsWindowWinTest::GetMTPStorageInfo(
+    const std::string& storage_device_id,
+    string16* pnp_device_id,
+    string16* storage_object_id) {
+  return window_->GetMTPStorageInfoFromDeviceId(storage_device_id,
+                                                pnp_device_id,
+                                                storage_object_id);
+}
+
 TEST_F(RemovableDeviceNotificationsWindowWinTest, RandomMessage) {
   window_->InjectDeviceChange(DBT_DEVICEQUERYREMOVE, NULL);
   RunUntilIdle();
 }
 
 TEST_F(RemovableDeviceNotificationsWindowWinTest, DevicesAttached) {
   DeviceIndices device_indices;
   device_indices.push_back(1);
   device_indices.push_back(5);
   device_indices.push_back(7);
@@ skipping 131 matching lines @@
 }
 
 // Attach a device with two data partitions. Verify that attach/detach
 // notifications are sent out for each removable storage.
 TEST_F(RemovableDeviceNotificationsWindowWinTest,
        MTPDeviceWithMultipleStorageObjects) {
   DoMTPDeviceTest(kMTPDeviceWithMultipleStorageObjects, true);
   DoMTPDeviceTest(kMTPDeviceWithMultipleStorageObjects, false);
 }
 
+// Given a MTP storage persistent id, GetMTPStorageInfo() should fetch the
+// device interface path and local storage object identifier.
+TEST_F(RemovableDeviceNotificationsWindowWinTest, GetMTPStorageInfo) {

[Lei Zhang, 2013/01/14 20:49:02]

nit: isn't this really testing GetMTPStorageInfoFromDeviceId ?

[kmadhusu, 2013/01/15 19:08:17]

Done.

+  DoMTPDeviceTest(kMTPDeviceWithValidInfo, true);
+  PortableDeviceWatcherWin::StorageObjects storage_objects =
+      GetDeviceStorageObjects(kMTPDeviceWithValidInfo);
+  for (PortableDeviceWatcherWin::StorageObjects::const_iterator it =
+       storage_objects.begin(); it != storage_objects.end(); ++it) {
+    string16 pnp_device_id;
+    string16 storage_object_id;
+    ASSERT_TRUE(GetMTPStorageInfo(it->object_persistent_id, &pnp_device_id,
+                                  &storage_object_id));
+    EXPECT_EQ(kMTPDeviceWithValidInfo, pnp_device_id);
+    EXPECT_EQ(it->object_persistent_id,
+              GetMTPStorageUniqueId(pnp_device_id, storage_object_id));
+  }
+
+  DoMTPDeviceTest(kMTPDeviceWithValidInfo, false);
+}
+
 }  // namespace chrome