[Media Gallery] Added code to support mtp device media file system on Windows.

chrome/browser/media_gallery/win/mtp_device_operations_util.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file contains util functions to support media filesystem operations.
+// It has several utility functions to open a media transfer protocol (MTP)
+// device for communication, to enumerate the device contents, to read the
+// device file object, etc. All these tasks may take an arbitary long time
+// to complete. This file segregates those functionalities and runs them
+// in the blocking pool thread rather than in the UI thread.
+
+#ifndef CHROME_BROWSER_MEDIA_GALLERY_WIN_MTP_DEVICE_OPERATIONS_UTIL_H_
+#define CHROME_BROWSER_MEDIA_GALLERY_WIN_MTP_DEVICE_OPERATIONS_UTIL_H_
+
+#include <portabledeviceapi.h>
+#include <string>
+
+#include "base/platform_file.h"
+#include "base/string16.h"
+#include "base/win/scoped_comptr.h"
+#include "chrome/browser/media_gallery/win/mtp_device_object_entry.h"
+
+namespace chrome {
+

[Ryan Sleevi, 2013/01/09 20:22:25]

namespace media_transfer_protocol { }?
namespace mtp { }? (not a particular fan of this)
namespace media_transfer { }?

[kmadhusu, 2013/01/10 04:59:19]

"media_transfer_protocol" is too generic. I prefer
"media_transfer_protocol_device_operations_utils". But it is too long.

[Ryan Sleevi, 2013/01/10 05:07:18]

media_transfer_protocol is not too generic for a namespace. Indeed, for
namespaces, you want generic names.

Perhaps I don't understand the concern here.

[kmadhusu, 2013/01/10 23:37:56]

Used media_transfer_protocol instead of
media_transfer_protocol_device_operations_utils.

+// Opens the device for communication. |pnp_device_id| specifies the plug and
+// play device ID string. On success, returns true and updates |device| with
+// the portable device interface.
+bool OpenDevice(const string16& pnp_device_id,
+                base::win::ScopedComPtr<IPortableDevice>* device);
+
+// Gets the details of the object specified by |object_id| from the given MTP
+// |device|. On success, fills in |file_entry_info|. On failure, returns the

[Ryan Sleevi, 2013/01/09 20:22:25]

nit: What does it return on success?

[kmadhusu, 2013/01/10 04:59:19]

No error (base::PLATFORM_FILE_OK). Fixed the comment.

+// corresponding platform file error and |file_entry_info| is not set.
+base::PlatformFileError GetFileEntryInfo(
+    IPortableDevice* device,
+    const string16& object_id,
+    base::PlatformFileInfo* file_entry_info);
+
+// Gets the entries of the directory specified by |directory_object_id| from
+// the given MTP |device|. On success, returns true and fills in
+// |object_entries|. On failure, returns false and |object_entries| are not

[Ryan Sleevi, 2013/01/09 20:22:25]

grammar: s/are not set/is not set/

While "entries" is plural, it's the name of a singular variable.

[kmadhusu, 2013/01/10 04:59:19]

Done.

+// set.
+bool GetDirectoryEntries(IPortableDevice* device,
+                         const string16& directory_object_id,
+                         MTPDeviceObjectEntries* object_entries);
+
+// Writes the data of the object specified by |file_object_id| from the given
+// MTP |device| to the file specified by |local_path|. On success, returns
+// true and writes the object data in |local_path|. On failure, returns false.
+bool WriteFileObjectData(IPortableDevice* device,
+                         const string16& file_object_id,
+                         const FilePath& local_path);
+
+// Returns the identifier of the object specified by the |object_name|.
+// |parent_id| specifies the object's parent identifier.
+string16 GetObjectIdFromName(IPortableDevice* device,
+                             const string16& parent_id,
+                             const string16& object_name);
+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_MEDIA_GALLERY_WIN_MTP_DEVICE_OPERATIONS_UTIL_H_