Disabled extensions in bug list now automatically removes the extension.

gpu/config/gpu_driver_bug_list_json.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Determines whether a certain driver bug exists in the current system.
 // The format of a valid gpu_driver_bug_list.json file is defined in
 // <gpu/config/gpu_control_list_format.txt>.
 // The supported "features" can be found in
 // <gpu/config/gpu_driver_bug_workaround_type.h>.
 
 #include "gpu/config/gpu_control_list_jsons.h"
 
 #define LONG_STRING_CONST(...) #__VA_ARGS__
 
 namespace gpu {
 
 const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
 
 {
   "name": "gpu driver bug list",
   // Please update the version number whenever you change this file.
-  "version": "8.01",
+  "version": "8.02",
   "entries": [
     {
       "id": 1,
       "description": "Imagination driver doesn't like uploading lots of buffer data constantly",
       "os": {
         "type": "android"
       },
       "gl_vendor": "Imagination.*",
       "features": [
         "use_client_side_arrays_for_stream_buffers"
@@ skipping 1269 matching lines @@
       "description": "Discard Framebuffer breaks WebGL on Mali-400 Linux",
       "cr_bugs": [485814],
       "os": {
         "type": "linux"
       },
       "gl_vendor": "ARM.*",
       "gl_renderer": ".*Mali-400.*",
       "features": [
         "disable_discard_framebuffer"
       ]
+    },
+    {
+      "id": 108,

[no sievers, 2015/05/15 18:31:51]

This collides with the same id defined above.
It *should* blow up at runtime, no? Same below for 109.

[David Yen, 2015/05/15 18:39:03]

Fixed. Although this didn't blow up at runtime... Is it because I don't have
"features" defined?

[no sievers, 2015/05/15 19:35:20]

Mind checking with zmo@ and potentially filing a bug if that's the case?
So that we don't silently end up with duplicate ids later.

[Zhenyao Mo, 2015/05/15 23:42:53]

OK, I will add a unittest for this.

+      "cr_bugs": [477514],
+      "description": "EXT_disjoint_timer_query fails after 2 queries on adreno 330 in lollypop",
+      "os": {
+        "type": "android",
+        "version": {
+          "op": ">=",

[no sievers, 2015/05/15 18:31:51]

You are sure this used to work in 5.0 and before?

[David Yen, 2015/05/15 18:39:03]

Yes, we even have a perf bot running GPU timing metrics for nexus 5 under kit
kat.

+          "value": "5.0.0"
+        }
+      },
+      "gl_vendor": "Qualcomm.*",
+      "gl_renderer": ".*330",

[no sievers, 2015/05/15 18:31:51]

Do you know that this works on other 3xx GPUs?
In fact do you know if it works on any Qualcomm driver?

There is also bug 453965, which your patch now allows us to address. (The DCHECK
was happening too early for the normal workaround mechanism to deal with it.)
You said you don't see this problem on Nexus 5?

[David Yen, 2015/05/15 18:39:04]

I believe the missing function problem only happens on Nexus 4 under lollypop
and later. I would rather just remove the DCHECK because that only affects Nexus
4. The functions that are missing are ones we do not use, so adding this
workaround to get around the DCHECK would disable gpu timing for nexus 4 which
we currently have running on perf bots under lollypop.

[David Yen, 2015/05/15 18:45:22]

Hmm, the missing functions for nexus 4 are not used but the moto-x functions
listed in the bug are actually used. What GPU does the moto-x use? We should
probably blacklist for that one as well.

[no sievers, 2015/05/15 19:35:20]

Adreno 320. Can you reference that bug also in here then?

I was wondering if you hit that DCHECK on Nexus 4. If these two bugs affect
different devices/drivers we should probably split them up in here.

[David Yen, 2015/05/15 23:44:13]

This one is for the Nexus 5 (330) so I don't think that bug should be referenced
here. I think we should figure out the state of 320, which driver versions it is
failing for, and add another bug entry for that.

+      "disabled_extensions": [
+        "GL_EXT_disjoint_timer_query"
+      ]
+    },
+    {
+      "id": 109,
+      "cr_bugs": [477514],
+      "description": "EXT_disjoint_timer_query fails after 2 queries on adreno 420",
+      "os": {
+        "type": "android"
+      },
+      "gl_vendor": "Qualcomm.*",
+      "gl_renderer": ".*420",
+      "disabled_extensions": [
+        "GL_EXT_disjoint_timer_query"
+      ]
     }
   ]
 }
 
 );  // LONG_STRING_CONST macro
 
 }  // namespace gpu