Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1129693003: Do we still need this DOUBLE_LOOP feature? (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do we still need this DOUBLE_LOOP feature? If so, let's do it this way so it works for all source types and doesn't need to be chosen at compile time. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6fbf4b3a7f0a3304649c482ab0a911dc147a6825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +6 lines, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 7 months ago (2015-05-06 17:45:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129693003/1
5 years, 7 months ago (2015-05-06 17:48:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 17:53:35 UTC) #6
joshualitt
On 2015/05/06 17:53:35, I haz the power (commit-bot) wrote: > Dry run: This issue passed ...
5 years, 7 months ago (2015-05-06 18:33:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129693003/1
5 years, 7 months ago (2015-05-06 18:35:29 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 18:35:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6fbf4b3a7f0a3304649c482ab0a911dc147a6825

Powered by Google App Engine
This is Rietveld 408576698