Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2370)

Unified Diff: device/bluetooth/bluetooth_adapter_android_unittest.cc

Issue 1129683002: bluetooth: Android adapter can be created with and without Bluetooth permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bta-jni-
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_adapter_android_unittest.cc
diff --git a/device/bluetooth/bluetooth_adapter_android_unittest.cc b/device/bluetooth/bluetooth_adapter_android_unittest.cc
index c4d5252e339c7a99f97c059bccfed78af6695902..5b73b8e2fd2be0ccf1ec6e9fbb365e4974e884b0 100644
--- a/device/bluetooth/bluetooth_adapter_android_unittest.cc
+++ b/device/bluetooth/bluetooth_adapter_android_unittest.cc
@@ -10,16 +10,41 @@ namespace device {
class BluetoothAdapterAndroidTest : public testing::Test {
protected:
- BluetoothAdapterAndroidTest() {
+ void InitWithPermission() {
adapter_ = BluetoothAdapterAndroid::CreateAdapter().get();
}
+ void InitWithoutPermission() {
+ adapter_ =
+ BluetoothAdapterAndroid::CreateAdapterWithoutPermissionForTesting()
+ .get();
+ }
+
scoped_refptr<BluetoothAdapterAndroid> adapter_;
};
TEST_F(BluetoothAdapterAndroidTest, Construct) {
+ InitWithPermission();
+ ASSERT_TRUE(adapter_.get());
+ EXPECT_TRUE(adapter_->HasBluetoothPermission());
Ted C 2015/05/07 22:23:57 what happens if these tests are running on a devic
scheib 2015/05/07 23:59:17 Good point. I've guarded the unit test with a dete
+ EXPECT_GT(adapter_->GetAddress().length(), 0u);
+ EXPECT_GT(adapter_->GetName().length(), 0u);
+ EXPECT_TRUE(adapter_->IsPresent());
+ EXPECT_TRUE(adapter_->IsPowered());
+ EXPECT_FALSE(adapter_->IsDiscoverable());
+ EXPECT_FALSE(adapter_->IsDiscovering());
+}
+
+TEST_F(BluetoothAdapterAndroidTest, ConstructNoPermision) {
+ InitWithoutPermission();
ASSERT_TRUE(adapter_.get());
EXPECT_FALSE(adapter_->HasBluetoothPermission());
+ EXPECT_EQ(adapter_->GetAddress().length(), 0u);
+ EXPECT_EQ(adapter_->GetName().length(), 0u);
+ EXPECT_FALSE(adapter_->IsPresent());
+ EXPECT_FALSE(adapter_->IsPowered());
+ EXPECT_FALSE(adapter_->IsDiscoverable());
+ EXPECT_FALSE(adapter_->IsDiscovering());
}
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698