Remove support for pseudo classes in <content select>.

Remove support for pseudo classes in <content select>.

This removes the ShadowDOMSiblingTraversalStrategy and un-templatizes the
SelectorChecker. It also removes all the distribution invalidation logic
related to pseudo classes changing.

For now we mark the web-platform-tests related to pseudos as failing,
an upstream patch will fix (or remove) the tests.

BUG=484953
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195027

[esprehn, 2015-05-06 23:55:40]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, hayato@chromium.org

[esprehn, 2015-05-06 23:57:52]

https://codereview.chromium.org/1129673002/diff/40001/Source/core/html/HTMLCo...
File Source/core/html/HTMLContentElement.cpp (right):

https://codereview.chromium.org/1129673002/diff/40001/Source/core/html/HTMLCo...
Source/core/html/HTMLContentElement.cpp:121:
SelectorChecker::SelectorCheckingContext context(*selector, &element,
SelectorChecker::VisitedMatchDisabled);
I also switched this to VisitedMatchDisabled. Since pseudos were disabled for
non-UA code before and we never used them in UA code this was essentially
impossible, but now it really is impossible by forcing it off like
querySelector. Previously if the
pseudoClassesInMatchingCriteriaInAuthorShadowTrees flag was enabled we
accidentally allowed matching :visited which is a privacy leak.

[esprehn, 2015-05-07 00:47:20]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 00:48:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129673002/40001

[commit-bot: I haz the power, 2015-05-07 01:53:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 01:53:29]

Dry run: This issue passed the CQ dry run.

[hayato, 2015-05-07 06:09:35]

lgtm since these are dead code in production. We don't have a plan to recover
these pseudo class supports in the near future.

I'm curious the motivation of removing. I guess the maintenance cost is much
bigger than the benefit of keeping these code.

[esprehn, 2015-05-07 06:12:57]

On 2015/05/07 at 06:09:35, hayato wrote:
> lgtm since these are dead code in production. We don't have a plan to recover
these pseudo class supports in the near future.
> 
> I'm curious the motivation of removing. I guess the maintenance cost is much
bigger than the benefit of keeping these code.

It makes the SelectorChecker more complicated, and it increases binary size
since we need to template stamp the whole SelectorChecker twice.

[esprehn, 2015-05-07 06:13:07]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2015-05-07 06:13:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129673002/40001

[commit-bot: I haz the power, 2015-05-07 06:17:50]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195027