Issue 1129653004: List blink tests individually in gn_migration.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129653004: List blink tests individually in gn_migration.gypi. (Closed)

Created:
5 years, 7 months ago by tfarina

Modified:
5 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

List blink tests individually in gn_migration.gypi. This is necessary because we want to remove the 'blink_tests' target from Blink (third_party/WebKit). BUG=483171 TEST=build/gyp_chromium R=dpranke@chromium.org Committed: https://crrev.com/71b7554b14c1ef97e8d4c487ab357b5dcef891dc Cr-Commit-Position: refs/heads/master@{#329739}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	build/gn_migration.gypi	View		3 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 7 (1 generated)

tfarina

Ping? This blocks https://codereview.chromium.org/1136343002/.

5 years, 7 months ago (2015-05-13 20:06:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129653004/1

5 years, 7 months ago (2015-05-13 20:42:12 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 22:44:25 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/71b7554b14c1ef97e8d4c487ab357b5dcef891dc
Cr-Commit-Position: refs/heads/master@{#329739}