Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: extensions/common/manifest_handlers/incognito_info.cc

Issue 112963005: Update uses of UTF conversions in courgette/, device/, extensions/, google_apis/, gpu/, ipc/, media… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/manifest_handlers/incognito_info.h" 5 #include "extensions/common/manifest_handlers/incognito_info.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "extensions/common/extension.h" 10 #include "extensions/common/extension.h"
(...skipping 30 matching lines...) Expand all
41 extension->SetManifestData( 41 extension->SetManifestData(
42 keys::kIncognito, 42 keys::kIncognito,
43 new IncognitoInfo(extension->is_hosted_app() || 43 new IncognitoInfo(extension->is_hosted_app() ||
44 extension->is_legacy_packaged_app())); 44 extension->is_legacy_packaged_app()));
45 return true; 45 return true;
46 } 46 }
47 47
48 bool split_mode = false; 48 bool split_mode = false;
49 std::string incognito_string; 49 std::string incognito_string;
50 if (!extension->manifest()->GetString(keys::kIncognito, &incognito_string)) { 50 if (!extension->manifest()->GetString(keys::kIncognito, &incognito_string)) {
51 *error = ASCIIToUTF16(manifest_errors::kInvalidIncognitoBehavior); 51 *error = base::ASCIIToUTF16(manifest_errors::kInvalidIncognitoBehavior);
52 return false; 52 return false;
53 } 53 }
54 54
55 if (incognito_string == manifest_values::kIncognitoSplit) 55 if (incognito_string == manifest_values::kIncognitoSplit)
56 split_mode = true; 56 split_mode = true;
57 else if (incognito_string != manifest_values::kIncognitoSpanning) { 57 else if (incognito_string != manifest_values::kIncognitoSpanning) {
58 // If incognito_string == kIncognitoSpanning, it is valid and 58 // If incognito_string == kIncognitoSpanning, it is valid and
59 // split_mode remains false. 59 // split_mode remains false.
60 *error = ASCIIToUTF16(manifest_errors::kInvalidIncognitoBehavior); 60 *error = base::ASCIIToUTF16(manifest_errors::kInvalidIncognitoBehavior);
61 return false; 61 return false;
62 } 62 }
63 63
64 extension->SetManifestData(keys::kIncognito, new IncognitoInfo(split_mode)); 64 extension->SetManifestData(keys::kIncognito, new IncognitoInfo(split_mode));
65 return true; 65 return true;
66 } 66 }
67 67
68 bool IncognitoHandler::AlwaysParseForType(Manifest::Type type) const { 68 bool IncognitoHandler::AlwaysParseForType(Manifest::Type type) const {
69 return true; 69 return true;
70 } 70 }
71 71
72 const std::vector<std::string> IncognitoHandler::Keys() const { 72 const std::vector<std::string> IncognitoHandler::Keys() const {
73 return SingleKey(keys::kIncognito); 73 return SingleKey(keys::kIncognito);
74 } 74 }
75 75
76 } // namespace extensions 76 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/manifest_handlers/csp_info.cc ('k') | extensions/common/manifest_handlers/kiosk_mode_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698