Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129603002: add DeferredCanvas mode to SampleApp (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add DeferredCanvas mode to SampleApp BUG=skia: Committed: https://skia.googlesource.com/skia/+/beedb81a7fa9bd1274d64b2c000ef6ee23c9a810

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M samplecode/SampleApp.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 8 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
reed1
ptal
5 years, 7 months ago (2015-05-05 18:30:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129603002/1
5 years, 7 months ago (2015-05-05 18:30:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 18:41:47 UTC) #6
robertphillips
lgtm + suggestion https://codereview.chromium.org/1129603002/diff/1/samplecode/SampleApp.h File samplecode/SampleApp.h (right): https://codereview.chromium.org/1129603002/diff/1/samplecode/SampleApp.h#newcode11 samplecode/SampleApp.h:11: #include "SkOSMenu.h" Just pre-decl rather than ...
5 years, 7 months ago (2015-05-05 18:53:34 UTC) #7
reed1
https://codereview.chromium.org/1129603002/diff/1/samplecode/SampleApp.h File samplecode/SampleApp.h (right): https://codereview.chromium.org/1129603002/diff/1/samplecode/SampleApp.h#newcode11 samplecode/SampleApp.h:11: #include "SkOSMenu.h" On 2015/05/05 18:53:33, robertphillips wrote: > Just ...
5 years, 7 months ago (2015-05-05 19:08:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129603002/20001
5 years, 7 months ago (2015-05-05 19:08:39 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 19:14:51 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/beedb81a7fa9bd1274d64b2c000ef6ee23c9a810

Powered by Google App Engine
This is Rietveld 408576698