src/d8.cc - Issue 1129543002: [d8] Make Realm.dispose() trigger a ContextDisposedNotification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 1129543002: [d8] Make Realm.dispose() trigger a ContextDisposedNotification (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 75bbf1d5ab1b2b3a41395f4f96e1a1e7f91d0aeb..7a300efe0ee621f79b4621a903913b0d9149449a 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -501,6 +501,8 @@ void Shell::RealmDispose(const v8::FunctionCallbackInfo<v8::Value>& args) {

return;

}

data->realms_[index].Reset();

+ isolate->ContextDisposedNotification();

+ isolate->IdleNotificationDeadline(g_platform->MonotonicallyIncreasingTime());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »