Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1129543002: [d8] Make Realm.dispose() trigger a ContextDisposedNotification (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Make Realm.dispose() trigger a ContextDisposedNotification Committed: https://crrev.com/04cc497aba07201be46acf8823179a438084b284 Cr-Commit-Position: refs/heads/master@{#28230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL.
5 years, 7 months ago (2015-05-05 13:25:11 UTC) #2
Toon Verwaest
lgtm
5 years, 7 months ago (2015-05-05 13:43:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129543002/1
5 years, 7 months ago (2015-05-05 13:53:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 14:25:27 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 14:25:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04cc497aba07201be46acf8823179a438084b284
Cr-Commit-Position: refs/heads/master@{#28230}

Powered by Google App Engine
This is Rietveld 408576698