Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1129533002: Oilpan: fix build after r194911. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-style_chromium.org, pdr., fs
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r194911. TBR=oilpan-reviews BUG=484004 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194921

Patch Set 1 #

Patch Set 2 : adjust position of Document clearing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/core/style/StyleFetchedImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/style/StyleFetchedImage.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sof
please take a look. A Persistent<Document> is unavoidable for StyleFetchedImage, as the use counter has ...
5 years, 7 months ago (2015-05-05 13:12:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129533002/20001
5 years, 7 months ago (2015-05-05 13:23:19 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194921
5 years, 7 months ago (2015-05-05 13:26:57 UTC) #4
haraken
LGTM > A Persistent<Document> is unavoidable for StyleFetchedImage, as the use counter > has to ...
5 years, 7 months ago (2015-05-05 15:57:57 UTC) #5
sof
5 years, 7 months ago (2015-05-05 17:33:53 UTC) #6
Message was sent while issue was closed.
On 2015/05/05 15:57:57, haraken wrote:
> LGTM
> 
> > A Persistent<Document> is unavoidable for StyleFetchedImage, as the use
> counter
> > has to be reported with respect to it.
> 
> Would it be possible to move StyleFetchedImage to the heap (and avoid the
> Persistent handle)?

I don't see any immediate problems with doing that, but it would entail moving
StyleImage & its derived classes.

Powered by Google App Engine
This is Rietveld 408576698