Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: PRESUBMIT.py

Issue 112953005: Remove NaCl SDK bots from top-level PRESUBMIT.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: whitespace change to force NaCl SDK tryjob Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/README.Makefiles » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5e64d57ed460d8138391209fd5f2161007609034..cb03322d7bf6bd74c5b400a657e8d7ac6926d4e1 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1271,6 +1271,7 @@ def GetDefaultTryConfigs(bots=None):
'sandbox_linux_unittests',
],
'linux_clang': ['compile'],
+ 'linux_nacl_sdk': [],
ghost stip (do not use) 2014/01/06 23:43:49 make these ['defaulttests']
binji 2014/01/06 23:55:24 Done.
'linux_rel': standard_tests + [
'cc_unittests',
'chromedriver_unittests',
@@ -1282,6 +1283,7 @@ def GetDefaultTryConfigs(bots=None):
'sync_integration_tests',
],
'mac': ['compile'],
+ 'mac_nacl_sdk': [],
'mac_rel': standard_tests + [
'app_list_unittests',
'cc_unittests',
@@ -1295,6 +1297,7 @@ def GetDefaultTryConfigs(bots=None):
'telemetry_unittests',
],
'win': ['compile'],
+ 'win_nacl_sdk': [],
'win_rel': standard_tests + [
'app_list_unittests',
'ash_unittests',
@@ -1384,12 +1387,6 @@ def GetPreferredTrySlaves(project, change):
'android_clang_dbg',
'android_dbg',
])
- if all(re.search('^native_client_sdk', f) for f in files):
- return GetDefaultTryConfigs([
- 'linux_nacl_sdk',
- 'mac_nacl_sdk',
- 'win_nacl_sdk',
- ])
if all(re.search('[/_]ios[/_.]', f) for f in files):
return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
@@ -1431,4 +1428,12 @@ def GetPreferredTrySlaves(project, change):
any(re.search('\.gypi?$', f) for f in files)):
trybots.extend(GetDefaultTryConfigs(['android_aosp']))
+ # Run native_client_sdk changes on the NaCl SDK trybots.
+ if any(re.search('^native_client_sdk', f) for f in files):
+ trybots.extend(GetDefaultTryConfigs([
+ 'linux_nacl_sdk',
+ 'mac_nacl_sdk',
+ 'win_nacl_sdk',
+ ]))
+
return trybots
« no previous file with comments | « no previous file | native_client_sdk/src/README.Makefiles » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698