Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: PRESUBMIT.py

Issue 112953005: Remove NaCl SDK bots from top-level PRESUBMIT.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove nacl_sdk from top-level PRESUBMIT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | native_client_sdk/src/README.Makefiles » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1366 matching lines...) Expand 10 before | Expand all | Expand 10 after
1377 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files): 1377 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files):
1378 return GetDefaultTryConfigs(['mac', 'mac_rel']) 1378 return GetDefaultTryConfigs(['mac', 'mac_rel'])
1379 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 1379 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
1380 return GetDefaultTryConfigs(['win', 'win_rel']) 1380 return GetDefaultTryConfigs(['win', 'win_rel'])
1381 if all(re.search('(^|[/_])android[/_.]', f) for f in files): 1381 if all(re.search('(^|[/_])android[/_.]', f) for f in files):
1382 return GetDefaultTryConfigs([ 1382 return GetDefaultTryConfigs([
1383 'android_aosp', 1383 'android_aosp',
1384 'android_clang_dbg', 1384 'android_clang_dbg',
1385 'android_dbg', 1385 'android_dbg',
1386 ]) 1386 ])
1387 if all(re.search('^native_client_sdk', f) for f in files):
1388 return GetDefaultTryConfigs([
1389 'linux_nacl_sdk',
1390 'mac_nacl_sdk',
1391 'win_nacl_sdk',
1392 ])
1393 if all(re.search('[/_]ios[/_.]', f) for f in files): 1387 if all(re.search('[/_]ios[/_.]', f) for f in files):
1394 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) 1388 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
1395 1389
1396 trybots = GetDefaultTryConfigs([ 1390 trybots = GetDefaultTryConfigs([
1397 'android_clang_dbg', 1391 'android_clang_dbg',
1398 'android_dbg', 1392 'android_dbg',
1399 'ios_dbg_simulator', 1393 'ios_dbg_simulator',
1400 'ios_rel_device', 1394 'ios_rel_device',
1401 'linux_aura', 1395 'linux_aura',
1402 'linux_asan', 1396 'linux_asan',
(...skipping 22 matching lines...) Expand all
1425 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1419 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1426 1420
1427 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1421 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1428 # unless they're .gyp(i) files as changes to those files can break the gyp 1422 # unless they're .gyp(i) files as changes to those files can break the gyp
1429 # step on that bot. 1423 # step on that bot.
1430 if (not all(re.search('^chrome', f) for f in files) or 1424 if (not all(re.search('^chrome', f) for f in files) or
1431 any(re.search('\.gypi?$', f) for f in files)): 1425 any(re.search('\.gypi?$', f) for f in files)):
1432 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1426 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1433 1427
1434 return trybots 1428 return trybots
OLDNEW
« no previous file with comments | « no previous file | native_client_sdk/src/README.Makefiles » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698