Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 112953005: Remove NaCl SDK bots from top-level PRESUBMIT.py (Closed)

Created:
6 years, 11 months ago by binji
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove NaCl SDK bots from top-level PRESUBMIT.py This change was originally introduced to only run the NaCl SDK bots when all changes were to files in the native_client_sdk directory. This change is no longer safe, as some changes can affect other builders (such as changes to create_nmf.py and nacl_io). BUG=none R=stip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243396

Patch Set 1 #

Patch Set 2 : whitespace change to force NaCl SDK tryjob #

Total comments: 2

Patch Set 3 : use defaulttests #

Patch Set 4 : remove nacl_sdk from top-level PRESUBMIT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M PRESUBMIT.py View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M native_client_sdk/src/README.Makefiles View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
binji
I'm not certain this is the correct change, but without it "git cl try" doesn't ...
6 years, 11 months ago (2014-01-06 23:36:56 UTC) #1
ghost stip (do not use)
thanks for making this change, just need to make it ['defaulttests'] instead of [] https://codereview.chromium.org/112953005/diff/30001/PRESUBMIT.py ...
6 years, 11 months ago (2014-01-06 23:43:49 UTC) #2
binji
https://codereview.chromium.org/112953005/diff/30001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/112953005/diff/30001/PRESUBMIT.py#newcode1274 PRESUBMIT.py:1274: 'linux_nacl_sdk': [], On 2014/01/06 23:43:49, stip wrote: > make ...
6 years, 11 months ago (2014-01-06 23:55:24 UTC) #3
binji
I just remembered that we already have these bots in native_client_sdk/PRESUBMIT.py, so I've removed it ...
6 years, 11 months ago (2014-01-07 00:03:12 UTC) #4
ghost stip (do not use)
cool, lgtm
6 years, 11 months ago (2014-01-07 00:36:26 UTC) #5
M-A Ruel
lgtm but please wrap the CL description to 72 or 80 cols. You can do ...
6 years, 11 months ago (2014-01-07 14:03:11 UTC) #6
binji
On 2014/01/07 14:03:11, M-A Ruel wrote: > lgtm but please wrap the CL description to ...
6 years, 11 months ago (2014-01-07 18:45:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/112953005/160001
6 years, 11 months ago (2014-01-07 18:54:56 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 21:53:11 UTC) #9
Message was sent while issue was closed.
Change committed as 243396

Powered by Google App Engine
This is Rietveld 408576698