Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1129483003: Disable RunAllocate test case for turbofan unsupported platform. (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable RunAllocate test case for turbofan unsupported platform. "RunAllocate" test case is added in d6945db7. it invokes Linkage::GetStubCallDescriptor which is unimplemented for turbofan unsupported platform. BUG= Committed: https://crrev.com/1f28a3df0778b2fb00330f95ab3a1c1aaf3c83aa Cr-Commit-Position: refs/heads/master@{#28244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-05 07:37:19 UTC) #2
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-05 07:47:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129483003/1
5 years, 7 months ago (2015-05-06 01:40:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 02:04:56 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 02:05:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f28a3df0778b2fb00330f95ab3a1c1aaf3c83aa
Cr-Commit-Position: refs/heads/master@{#28244}

Powered by Google App Engine
This is Rietveld 408576698