Source/bindings/core/v8/ScriptDebugServer.h - Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.h

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comments, added checks in DOMDebugger Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptDebugServer.h

diff --git a/Source/bindings/core/v8/ScriptDebugServer.h b/Source/bindings/core/v8/ScriptDebugServer.h

index 7d4f6b9db1490f3b1b58ec0f5cfa6e0a2154b552..62a1a889020c8f854273b0e04fde47432c96f6c2 100644

--- a/Source/bindings/core/v8/ScriptDebugServer.h

+++ b/Source/bindings/core/v8/ScriptDebugServer.h

@@ -131,7 +131,7 @@ protected:

virtual void quitMessageLoopOnPause() = 0;

private:

- void ensureDebuggerScriptCompiled();

+ void compileDebuggerScript();

v8::MaybeLocal<v8::Value> callDebuggerMethod(const char* functionName, int argc, v8::Local<v8::Value> argv[]);

v8::Local<v8::Object> debuggerScriptLocal() const;

void clearBreakpoints();

« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptDebugServer.cpp » ('j') | Source/core/inspector/CodeGeneratorInspector.py » ('J')