Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments, added checks in DOMDebugger Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 } 173 }
174 174
175 void InspectorDebuggerAgent::init() 175 void InspectorDebuggerAgent::init()
176 { 176 {
177 m_promiseTracker = PromiseTracker::create(this, scriptDebugServer().isolate( )); 177 m_promiseTracker = PromiseTracker::create(this, scriptDebugServer().isolate( ));
178 // FIXME: make breakReason optional so that there was no need to init it wit h "other". 178 // FIXME: make breakReason optional so that there was no need to init it wit h "other".
179 clearBreakDetails(); 179 clearBreakDetails();
180 m_state->setLong(DebuggerAgentState::pauseOnExceptionsState, ScriptDebugServ er::DontPauseOnExceptions); 180 m_state->setLong(DebuggerAgentState::pauseOnExceptionsState, ScriptDebugServ er::DontPauseOnExceptions);
181 } 181 }
182 182
183 bool InspectorDebuggerAgent::checkEnabled(ErrorString* errorString)
184 {
185 if (enabled())
186 return true;
187 *errorString = "Debugger agent is not enabled";
188 return false;
189 }
190
183 void InspectorDebuggerAgent::enable() 191 void InspectorDebuggerAgent::enable()
184 { 192 {
185 m_instrumentingAgents->setInspectorDebuggerAgent(this); 193 m_instrumentingAgents->setInspectorDebuggerAgent(this);
186 194
187 startListeningScriptDebugServer(); 195 startListeningScriptDebugServer();
188 // FIXME(WK44513): breakpoints activated flag should be synchronized between all front-ends 196 // FIXME(WK44513): breakpoints activated flag should be synchronized between all front-ends
189 scriptDebugServer().setBreakpointsActivated(true); 197 scriptDebugServer().setBreakpointsActivated(true);
190 198
191 m_state->setBoolean(DebuggerAgentState::debuggerEnabled, true); 199 m_state->setBoolean(DebuggerAgentState::debuggerEnabled, true);
192 if (m_listener) 200 if (m_listener)
(...skipping 1435 matching lines...) Expand 10 before | Expand all | Expand 10 after
1628 visitor->trace(m_v8AsyncCallTracker); 1636 visitor->trace(m_v8AsyncCallTracker);
1629 visitor->trace(m_promiseTracker); 1637 visitor->trace(m_promiseTracker);
1630 visitor->trace(m_asyncOperations); 1638 visitor->trace(m_asyncOperations);
1631 visitor->trace(m_currentAsyncCallChain); 1639 visitor->trace(m_currentAsyncCallChain);
1632 visitor->trace(m_asyncCallTrackingListeners); 1640 visitor->trace(m_asyncCallTrackingListeners);
1633 #endif 1641 #endif
1634 InspectorBaseAgent::trace(visitor); 1642 InspectorBaseAgent::trace(visitor);
1635 } 1643 }
1636 1644
1637 } // namespace blink 1645 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698