Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments, added checks in DOMDebugger Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 void didCancelAnimationFrame(ExecutionContext*, int callbackId); 91 void didCancelAnimationFrame(ExecutionContext*, int callbackId);
92 void willFireAnimationFrame(ExecutionContext*, int callbackId); 92 void willFireAnimationFrame(ExecutionContext*, int callbackId);
93 void willHandleEvent(EventTarget*, Event*, EventListener*, bool useCapture); 93 void willHandleEvent(EventTarget*, Event*, EventListener*, bool useCapture);
94 void willEvaluateScript(LocalFrame*, const String& url, int lineNumber); 94 void willEvaluateScript(LocalFrame*, const String& url, int lineNumber);
95 void didFireWebGLError(const String& errorName); 95 void didFireWebGLError(const String& errorName);
96 void didFireWebGLWarning(); 96 void didFireWebGLWarning();
97 void didFireWebGLErrorOrWarning(const String& message); 97 void didFireWebGLErrorOrWarning(const String& message);
98 void willCloseWindow(); 98 void willCloseWindow();
99 99
100 void disable(ErrorString*) override; 100 void disable(ErrorString*) override;
101 bool checkEnabled(ErrorString*) override;
101 void discardAgent() override; 102 void discardAgent() override;
102 103
103 private: 104 private:
104 InspectorDOMDebuggerAgent(InspectorDOMAgent*, InspectorDebuggerAgent*); 105 InspectorDOMDebuggerAgent(InspectorDOMAgent*, InspectorDebuggerAgent*);
105 106
106 void pauseOnNativeEventIfNeeded(PassRefPtr<JSONObject> eventData, bool synch ronous); 107 void pauseOnNativeEventIfNeeded(PassRefPtr<JSONObject> eventData, bool synch ronous);
107 PassRefPtr<JSONObject> preparePauseOnNativeEventData(const String& eventName , const String* targetName); 108 PassRefPtr<JSONObject> preparePauseOnNativeEventData(const String& eventName , const String* targetName);
108 109
109 // InspectorDOMAgent::Listener implementation. 110 // InspectorDOMAgent::Listener implementation.
110 void domAgentWasEnabled() override; 111 void domAgentWasEnabled() override;
(...skipping 17 matching lines...) Expand all
128 129
129 RawPtrWillBeMember<InspectorDOMAgent> m_domAgent; 130 RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;
130 RawPtrWillBeMember<InspectorDebuggerAgent> m_debuggerAgent; 131 RawPtrWillBeMember<InspectorDebuggerAgent> m_debuggerAgent;
131 WillBeHeapHashMap<RawPtrWillBeMember<Node>, uint32_t> m_domBreakpoints; 132 WillBeHeapHashMap<RawPtrWillBeMember<Node>, uint32_t> m_domBreakpoints;
132 }; 133 };
133 134
134 } // namespace blink 135 } // namespace blink
135 136
136 137
137 #endif // !defined(InspectorDOMDebuggerAgent_h) 138 #endif // !defined(InspectorDOMDebuggerAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698