Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: Source/core/inspector/CodeGeneratorInspectorStrings.py

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments, added checks in DOMDebugger Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2013 Google Inc. All rights reserved. 1 # Copyright (c) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 """void InspectorBackendDispatcherImpl::${domainName}_$methodName(int callId, JS ONObject*$requestMessageObject, JSONArray* protocolErrors) 46 """void InspectorBackendDispatcherImpl::${domainName}_$methodName(int callId, JS ONObject*$requestMessageObject, JSONArray* protocolErrors)
47 { 47 {
48 if (!$agentField) 48 if (!$agentField)
49 protocolErrors->pushString("${domainName} handler is not available."); 49 protocolErrors->pushString("${domainName} handler is not available.");
50 $methodCode 50 $methodCode
51 if (protocolErrors->length()) { 51 if (protocolErrors->length()) {
52 reportProtocolError(callId, InvalidParams, String::format(InvalidParamsF ormatString, commandName($commandNameIndex)), protocolErrors); 52 reportProtocolError(callId, InvalidParams, String::format(InvalidParamsF ormatString, commandName($commandNameIndex)), protocolErrors);
53 return; 53 return;
54 } 54 }
55 $agentCallParamsDeclaration 55 $agentCallParamsDeclaration
56 $agentEnablementCheck
56 $agentField->$methodName($agentCallParams); 57 $agentField->$methodName($agentCallParams);
57 $responseCook 58 $responseCook
58 sendResponse(callId, $sendResponseCallParams); 59 sendResponse(callId, $sendResponseCallParams);
59 } 60 }
60 """) 61 """)
61 62
62 frontend_method = ("""void InspectorFrontend::$domainName::$eventName($parameter s) 63 frontend_method = ("""void InspectorFrontend::$domainName::$eventName($parameter s)
63 { 64 {
64 RefPtr<JSONObject> jsonMessage = JSONObject::create(); 65 RefPtr<JSONObject> jsonMessage = JSONObject::create();
65 jsonMessage->setString("method", "$domainName.$eventName"); 66 jsonMessage->setString("method", "$domainName.$eventName");
(...skipping 839 matching lines...) Expand 10 before | Expand all | Expand 10 after
905 }; 906 };
906 907
907 """) 908 """)
908 909
909 class_binding_builder_part_4 = ( 910 class_binding_builder_part_4 = (
910 """ static Builder<NoFieldsSet> create() 911 """ static Builder<NoFieldsSet> create()
911 { 912 {
912 return Builder<NoFieldsSet>(JSONObject::create()); 913 return Builder<NoFieldsSet>(JSONObject::create());
913 } 914 }
914 """) 915 """)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698