Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1129473002: Revert of Add CompleteRead to SequencedSocketData and convert all but 3 tests (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CompleteRead to SequencedSocketData and convert all but 3 tests (patchset #2 id:20001 of https://codereview.chromium.org/1124533002/) Reason for revert: Suspected of having broken net_unittests on Win 7: https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1)/builds/1337 https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/38402 Also unblocks revert of previous, dependent CL. Original issue's description: > Add CompleteRead to SequencedSocketData and convert all but 3 tests > to use SequencedSocketData. Reduces runtime to 7 seconds from 11 seconds on my linux workstation > > BUG=332112 > > Committed: https://crrev.com/d7b1887392866667126162a4e7854a2736449970 > Cr-Commit-Position: refs/heads/master@{#328221} TBR=rtenneti@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=332112 Committed: https://crrev.com/cd6674c77dbeaa9c17bdf2dea1ca1c521649c8fa Cr-Commit-Position: refs/heads/master@{#328252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -154 lines) Patch
M net/http/http_network_transaction_unittest.cc View 4 chunks +10 lines, -18 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/socket/socket_test_util.cc View 6 chunks +11 lines, -36 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 14 chunks +81 lines, -68 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Add CompleteRead to SequencedSocketData and convert all but 3 tests
5 years, 7 months ago (2015-05-05 01:55:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129473002/1
5 years, 7 months ago (2015-05-05 01:56:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 01:58:06 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 01:59:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd6674c77dbeaa9c17bdf2dea1ca1c521649c8fa
Cr-Commit-Position: refs/heads/master@{#328252}

Powered by Google App Engine
This is Rietveld 408576698