Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: ui/touch_selection/touch_selection_controller.cc

Issue 1129443006: Increase the slop value for text selection offsets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/touch_selection/touch_selection_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/touch_selection/touch_selection_controller.cc
diff --git a/ui/touch_selection/touch_selection_controller.cc b/ui/touch_selection/touch_selection_controller.cc
index a5facdcba480a20084fc5b5cb08e7080aeffd779..ea5db91a766055c25968c6ea1f9eec101dc2fe66 100644
--- a/ui/touch_selection/touch_selection_controller.cc
+++ b/ui/touch_selection/touch_selection_controller.cc
@@ -14,10 +14,10 @@ namespace {
gfx::Vector2dF ComputeLineOffsetFromBottom(const SelectionBound& bound) {
gfx::Vector2dF line_offset =
gfx::ScaleVector2d(bound.edge_top() - bound.edge_bottom(), 0.5f);
- // An offset of 5 DIPs is sufficient for most line sizes. For small lines,
+ // An offset of 8 DIPs is sufficient for most line sizes. For small lines,
// using half the line height avoids synthesizing a point on a line above
// (or below) the intended line.
- const gfx::Vector2dF kMaxLineOffset(5.f, 5.f);
+ const gfx::Vector2dF kMaxLineOffset(8.f, 8.f);
line_offset.SetToMin(kMaxLineOffset);
line_offset.SetToMax(-kMaxLineOffset);
return line_offset;
« no previous file with comments | « no previous file | ui/touch_selection/touch_selection_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698