Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1129443006: Increase the slop value for text selection offsets (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 6 months ago
Reviewers:
mohsen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase the slop value for text selection offsets A small selection offset is used when a selection handle is dragged to ensure the coordinate sent to the renderer is on the correct line of text. Increase the 'slop' value of this offset to accomodate lines/fonts with significant whitespace below the actual text visuals. BUG=484479 Committed: https://crrev.com/efa4c8123c23646e6d3e5df65b60e76aa8ed59d8 Cr-Commit-Position: refs/heads/master@{#332522}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/touch_selection/touch_selection_controller.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
jdduke (slow)
mohsen@: PTAL. I thought of doing some more sophisticated handle re-anchoring, but it doesn't work ...
5 years, 7 months ago (2015-05-05 19:02:52 UTC) #2
jdduke (slow)
Hmm, I've started noticing this issue more, and until we have a more permanent fix ...
5 years, 6 months ago (2015-06-02 18:48:04 UTC) #3
mohsen
On 2015/06/02 18:48:04, jdduke wrote: > Hmm, I've started noticing this issue more, and until ...
5 years, 6 months ago (2015-06-02 19:05:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129443006/20001
5 years, 6 months ago (2015-06-02 19:15:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/65021)
5 years, 6 months ago (2015-06-02 19:33:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129443006/20001
5 years, 6 months ago (2015-06-02 19:43:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/70830)
5 years, 6 months ago (2015-06-02 20:19:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129443006/40001
5 years, 6 months ago (2015-06-02 23:48:53 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 03:12:16 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 03:13:14 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/efa4c8123c23646e6d3e5df65b60e76aa8ed59d8
Cr-Commit-Position: refs/heads/master@{#332522}

Powered by Google App Engine
This is Rietveld 408576698