Issue 1129443005: Add presubmit to run `{dm,nanobench}_flags.py test` when changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129443005: Add presubmit to run `{dm,nanobench}_flags.py test` when changed. (Closed)

Created:
5 years, 7 months ago by mtklein_C

Modified:
5 years, 7 months ago

Reviewers:
borenet, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Add presubmit to run `{dm,nanobench}_flags.py test` when changed. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e4b19c4593da5179b346b66b291e8f4f45af617f

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+341 lines, -0 lines)			Patch
M	PRESUBMIT.py	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	tools/dm_flags.json	View		2 chunks	+310 lines, -0 lines	0 comments	Download
M	tools/dm_flags.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/nanobench_flags.json	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

borenet

Thanks, I'm sure I break this every time I look at it. LGTM

5 years, 7 months ago (2015-05-05 16:53:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129443005/40001

5 years, 7 months ago (2015-05-05 17:22:50 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-05 17:28:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e4b19c4593da5179b346b66b291e8f4f45af617f