Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1129413002: SkPictureShader: floor scaledSize not to exceed maxTextureSize (Closed)

Created:
5 years, 7 months ago by gen.kim
Modified:
5 years, 7 months ago
Reviewers:
f(malita), bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPictureShader: floor scaledSize not to exceed maxTextureSize scaledSize becomes larger than maxTextureSize by zoom level because it is rounded. BUG=chromium:485916 Committed: https://skia.googlesource.com/skia/+/88f12dbe926df806cfb5b0641f613a2e256a713b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkPictureShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
gen.kim
PTAL
5 years, 7 months ago (2015-05-08 09:45:37 UTC) #2
f(malita)
lgtm
5 years, 7 months ago (2015-05-08 13:44:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129413002/1
5 years, 7 months ago (2015-05-11 01:26:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 01:32:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129413002/1
5 years, 7 months ago (2015-05-11 01:33:18 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 01:33:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/88f12dbe926df806cfb5b0641f613a2e256a713b

Powered by Google App Engine
This is Rietveld 408576698