Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1129403003: Adding total available size of heap in v8 isolate memory dump provider. (Closed)

Created:
5 years, 7 months ago by ssid
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding total available size of heap in v8 isolate memory dump provider. The total available size is now returned by GetHeapStatistics api. This CL uses the value in the dump provider to show the value in other_spaces segment of the memory dump. BUG=481504 Committed: https://crrev.com/9ad94e6e06201059c08d67b9d9ab4a30a766b541 Cr-Commit-Position: refs/heads/master@{#329303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M gin/v8_isolate_memory_dump_provider.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ssid
PTAL.
5 years, 7 months ago (2015-05-08 17:08:41 UTC) #2
Primiano Tucci (use gerrit)
LGTM thanks. +jochen for an OWNER stamp
5 years, 7 months ago (2015-05-11 09:15:47 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-11 23:31:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129403003/1
5 years, 7 months ago (2015-05-12 00:01:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 01:01:29 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ad94e6e06201059c08d67b9d9ab4a30a766b541 Cr-Commit-Position: refs/heads/master@{#329303}
5 years, 7 months ago (2015-05-12 01:02:20 UTC) #9
ssid
5 years, 7 months ago (2015-05-12 16:19:31 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1134233002/ by ssid@chromium.org.

The reason for reverting is: The HeapStatistics::total_available_size returned
by v8 API doesn't return the correct value right now. It only returns the sum of
available size of 4 spaces only. So, this should land after the API gets fixed..

Powered by Google App Engine
This is Rietveld 408576698