Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1129383006: Add chrome://flags entry for --try-supported-channel-layouts (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://flags entry for --try-supported-channel-layouts Allows stereo channel expansion for many users. We unfortunately can't turn it on for everyone due to bugs in third party drive implementations :( -- see http://crbug.com/259165 Many users have been using this flag diligently for a while now, but every Chrome update wipes the flag, so make it a chrome://flag to improve usability for these users. BUG=479057 TEST=none Committed: https://crrev.com/8e5e2f47b4fc3efebac06b8c1ff0a5e049a95be2 Cr-Commit-Position: refs/heads/master@{#329662}

Patch Set 1 : Fix histogram. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +10 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
DaleCurtis
5 years, 7 months ago (2015-05-12 18:19:22 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-12 18:20:44 UTC) #6
henrika (OOO until Aug 14)
Thanks! LGTM
5 years, 7 months ago (2015-05-13 06:50:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129383006/60001
5 years, 7 months ago (2015-05-13 16:11:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 7 months ago (2015-05-13 17:16:59 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:17:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e5e2f47b4fc3efebac06b8c1ff0a5e049a95be2
Cr-Commit-Position: refs/heads/master@{#329662}

Powered by Google App Engine
This is Rietveld 408576698