New return value syntax for HashTable and HashMap nested types

New return value syntax for HashTable and HashMap nested types

Add some sugar to improve readability.

[Mikhail, 2015-05-08 11:24:21]

mikhail.pozdnyakov@intel.com changed reviewers:
+ jochen@chromium.org

[Mikhail, 2015-05-08 11:24:35]

PTAL

[jochen (gone - plz use gerrit), 2015-05-08 17:22:24]

any particular reason to change this?

[Mikhail, 2015-05-11 08:06:58]

On 2015/05/08 17:22:24, jochen (traveling) wrote:
> any particular reason to change this?

as I wrote this is just a syntax sugar :) however that makes method's definition
significantly more compact and the code is easier to comprehend.

[jochen (gone - plz use gerrit), 2015-05-11 23:31:12]

On 2015/05/11 at 08:06:58, mikhail.pozdnyakov wrote:
> On 2015/05/08 17:22:24, jochen (traveling) wrote:
> > any particular reason to change this?
> 
> as I wrote this is just a syntax sugar :) however that makes method's
definition significantly more compact and the code is easier to comprehend.

I don't think that we should do changes like this without an actual need, sorry.

[Mikhail, 2015-05-12 11:08:14]

On 2015/05/11 23:31:12, jochen (traveling) wrote:
> On 2015/05/11 at 08:06:58, mikhail.pozdnyakov wrote:
> > On 2015/05/08 17:22:24, jochen (traveling) wrote:
> > > any particular reason to change this?
> > 
> > as I wrote this is just a syntax sugar :) however that makes method's
> definition significantly more compact and the code is easier to comprehend.
> 
> I don't think that we should do changes like this without an actual need,
sorry.

No problem, I understand your point for being reluctant to non-functional
changes, however in this particular case I do not see the alternative -- we will
hardly ever re-write the whole HashTable/HashMap classes so that the new
semantics would come naturally.. at the same time this new semantics simplifies
reading code quite a lot. I'd say it was invented exactly for such cases like
"inline typename HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyT
raits, Allocator>::FullLookupType HashTable<Key, Value, Extractor, HashFunctions
, Traits, KeyTraits, .. (and you've to scroll to see the method name)"