Move Google Cache copy suggestion to an action button in the neterror interstitial

chrome/renderer/resources/neterror.js

Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 043a79087c48ce55ba3738a048aae8d4084529a7..bad0bd4bbec07b245c142e52ff1a2d16200fce81 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -113,13 +113,32 @@ function detailsButtonClick() {
     errorPageController.detailsButtonClick();
 }
 
+/**
+ * Replace the reload button with the Google cached copy suggestion.
+ */
+function setupCachedButton(buttonStrings) {

[mmenke, 2015/05/13 14:58:40]

nit:  setUp ("setup" is a noun, want "set up" here)

[edwardjung, 2015/05/13 17:34:34]

Done.

+  var reloadButton = document.getElementById('reload-button');
+
+  reloadButton.textContent = buttonStrings.msg;
+  reloadButton.url = buttonStrings.cacheUrl;

[arv (Not doing code reviews), 2015/05/13 14:26:22]

No need to add expandos here and below.

+  reloadButton.trackingid = buttonStrings.trackingId;

[arv (Not doing code reviews), 2015/05/13 14:26:22]

trackingid -> trackingId

[edwardjung, 2015/05/13 17:34:34]

Done.

+  reloadButton.removeAttribute('onclick');

[arv (Not doing code reviews), 2015/05/13 14:26:22]

Why? Instead of using addEventListener on the next line you can just assign to
onclick

reloadButton.onclick = function(e) {

and it will replace the existing one.

[edwardjung, 2015/05/13 17:34:34]

Good point.

+  reloadButton.addEventListener('click', function(e) {
+      e.preventDefault();

[arv (Not doing code reviews), 2015/05/13 14:26:22]

wrong indentation

[edwardjung, 2015/05/13 17:34:34]

Done.

+      var el = e.currentTarget;
+      trackClick(el.trackingid);
+      location = el.url;
+    });

[arv (Not doing code reviews), 2015/05/13 14:26:22]

OK. Here is what you will end up with:

var url = buttonStrings.cacheUrl;
var trackingid = buttonStrings.trackingId;
reloadButton.onclick = function(e) {
  e.preventDefault();
  trackClick(trackingId);
  location = url;
};

[edwardjung, 2015/05/13 17:34:34]

Done.

+  reloadButton.style.display = '';
+  document.getElementById('control-buttons').hidden = false;
+}
+
 var primaryControlOnLeft = true;
 <if expr="is_macosx or is_ios or is_linux or is_android">
 primaryControlOnLeft = false;
 </if>
 
 function onDocumentLoad() {
-  var buttonsDiv = document.getElementById('buttons');
   var controlButtonDiv = document.getElementById('control-buttons');
   var reloadButton = document.getElementById('reload-button');
   var detailsButton = document.getElementById('details-button');
@@ -178,6 +197,11 @@ function onDocumentLoad() {
     p.innerHTML = loadTimeData.getString('primaryParagraph');
     p.hidden = false;
   }
+
+  // Check for Google cached copy suggestion.
+  if (loadTimeData.valueExists('cacheButton')) {
+    setupCachedButton(loadTimeData.getValue('cacheButton'));
+  }
 }
 
 document.addEventListener('DOMContentLoaded', onDocumentLoad);