Move Google Cache copy suggestion to an action button in the neterror interstitial

chrome/renderer/resources/neterror.js

Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 043a79087c48ce55ba3738a048aae8d4084529a7..6bd158b8adfbd1289800f7bff67c5d873c8c5cef 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -113,13 +113,32 @@ function detailsButtonClick() {
     errorPageController.detailsButtonClick();
 }
 
+/**
+ * Replace the reload button with the Google cached copy suggestion.
+ */
+function setupCachedButton(buttonStrings) {
+  var reloadButton = document.getElementById('reload-button');
+
+  reloadButton.textContent = buttonStrings.msg;
+  reloadButton.onclick = '';

[felt, 2015/05/11 20:49:01]

should this be removeEventListener? or are you stuck doing onclick = '' because
the other function isn't named?

[edwardjung, 2015/05/12 10:16:50]

removeEventListener only works on events registered with addEventListener. I
actually realised this doesn't work properly and should have used
removeAttribute instead.

+  reloadButton.url = buttonStrings.cacheUrl;
+  reloadButton.trackingid = buttonStrings.trackingId;
+  reloadButton.addEventListener('click', function(e) {
+      e.preventDefault();
+      var el = e.currentTarget;
+      trackClick(el.trackingid);
+      location = el.url;
+    });
+  reloadButton.style.display = '';
+  document.getElementById('control-buttons').hidden = false;
+}
+
 var primaryControlOnLeft = true;
 <if expr="is_macosx or is_ios or is_linux or is_android">
 primaryControlOnLeft = false;
 </if>
 
 function onDocumentLoad() {
-  var buttonsDiv = document.getElementById('buttons');
   var controlButtonDiv = document.getElementById('control-buttons');
   var reloadButton = document.getElementById('reload-button');
   var detailsButton = document.getElementById('details-button');
@@ -178,6 +197,11 @@ function onDocumentLoad() {
     p.innerHTML = loadTimeData.getString('primaryParagraph');
     p.hidden = false;
   }
+
+  // Check for Google cached copy suggestion.
+  if (loadTimeData.valueExists('cacheButton')) {
+    setupCachedButton(loadTimeData.getValue('cacheButton'));
+  }
 }
 
 document.addEventListener('DOMContentLoaded', onDocumentLoad);