Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: chrome/renderer/resources/neterror.js

Issue 1129353005: Move Google Cache copy suggestion to an action button in the neterror interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix size_t to int data loss warning Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/neterror.css ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 043a79087c48ce55ba3738a048aae8d4084529a7..e468ab9d2cfda0d82c2ae405281c1a18801b9644 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -113,13 +113,30 @@ function detailsButtonClick() {
errorPageController.detailsButtonClick();
}
+/**
+ * Replace the reload button with the Google cached copy suggestion.
+ */
+function setUpCachedButton(buttonStrings) {
+ var reloadButton = document.getElementById('reload-button');
+
+ reloadButton.textContent = buttonStrings.msg;
+ var url = buttonStrings.cacheUrl;
+ var trackingId = buttonStrings.trackingId;
+ reloadButton.onclick = function(e) {
+ e.preventDefault();
+ trackClick(trackingId);
+ location = url;
+ };
+ reloadButton.style.display = '';
+ document.getElementById('control-buttons').hidden = false;
+}
+
var primaryControlOnLeft = true;
<if expr="is_macosx or is_ios or is_linux or is_android">
primaryControlOnLeft = false;
</if>
function onDocumentLoad() {
- var buttonsDiv = document.getElementById('buttons');
var controlButtonDiv = document.getElementById('control-buttons');
var reloadButton = document.getElementById('reload-button');
var detailsButton = document.getElementById('details-button');
@@ -178,6 +195,11 @@ function onDocumentLoad() {
p.innerHTML = loadTimeData.getString('primaryParagraph');
p.hidden = false;
}
+
+ // Check for Google cached copy suggestion.
+ if (loadTimeData.valueExists('cacheButton')) {
+ setUpCachedButton(loadTimeData.getValue('cacheButton'));
+ }
}
document.addEventListener('DOMContentLoaded', onDocumentLoad);
« no previous file with comments | « chrome/renderer/resources/neterror.css ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698